Repository navigation
Conversation
JC-Chung
marked this pull request as draft
October 6, 2026 09:20
JC-Chung
force-pushed
the
enhance/pie-chart-others-color
branch
2 times, most recently
from
October 7, 2026 02:18
77cd029 to
709d2e3
Compare
JC-Chung
force-pushed
the
enhance/pie-chart-others-color
branch
from
October 7, 2026 02:20
709d2e3 to
f405579
Compare
JC-Chung
marked this pull request as ready for review
October 7, 2026 02:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Othersslice withsecondaryForeground(Brush.FG2) instead of the next palette color. When the number of authors above 1% is a multiple of 10, the palette index wraps around to 0, makingOthersthe same Orange as the adjacent top-author slice — the two blend together with no visible boundary.BorderBrushproperty bound toBrush.Window. Without it, when all authors are above 1% and the count is 11/21/31..., the last author's slice is also Orange and adjacent to the top author's slice, which theOthersfix cannot cover.var brush = s_brushes[brushIndex]into thepercent > 0.01branch._lastHoverredto_lastHovered(no behavior change).