Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
==========================================
+ Coverage 83.78% 83.88% +0.10%
==========================================
Files 134 134
Lines 12691 12796 +105
==========================================
+ Hits 10633 10734 +101
- Misses 2058 2062 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
srikarjy
force-pushed
the
issue-3718-baseplot-aggregate
branch
from
October 5, 2026 17:56
0f0fbee to
12dd884
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preserve sparse and backed plotting inputs instead of eagerly building a dense cell-level dataframe in
BasePlotaggregate dotplot sizes/colors and matrixplot values with Scanpy aggregation kernels
keep
obs_tidylazy for plot types that still require cell-level valuespreserve
mean_only_expressedsemantics for nonzero expression cutoffsCloses Refactor
BasePlotnot to create a dataframe representation of the data #3718Tests included
Release notes not necessary because: a performance release note is included
Testing
uv run ruff checkon changed Python filesuv run ruff format --checkon changed Python files.venv/bin/python -m pytest tests/plotting/legacy/test_plotting.py -k "dotplot or matrixplot or stacked_violin" --disable-pytest-warnings -q(50 passed, 5 skipped, 2 xfailed)