Repository navigation
Compare the Pattern DSL prefix with the module name - #4244
Merged
Merged
Conversation
The pattern compiler accepted `Prism::CallNode` by comparing the parent constant with the literal string "Prism". Compare it with `Prism.name` instead, and also accept a constant path as the parent, so that the same code works when the library is loaded under another namespace. ruby/ruby is considering building prism into the interpreter as `Ruby::Prism` by rewriting the namespace when syncing from this repository (https://bugs.ruby-lang.org/issues/22379). The literal "Prism" here was the only place that did not follow the rewrite. For `Prism` itself, the behavior does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kddnewton
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism::PatternacceptsPrism::CallNodeby comparing the parent constant with the literal string"Prism". This compares it withPrism.nameinstead, and also accepts a constant path as the parent, so that the same code works when the library is loaded under another namespace. ForPrismitself, the behavior does not change.Background: in https://bugs.ruby-lang.org/issues/22379, ruby/ruby is considering building prism into the interpreter as
Ruby::Prism, by rewriting the namespace when syncing from this repository (PoC: ruby/ruby#19248). This literal was the only place that did not follow the rewrite. There, the pattern is written asRuby::Prism::CallNode(or justCallNode).