Skip to content

Fix alignment in the PR checks view - #9029

Merged
Alex Ross (alexr00) merged 2 commits into
mainfrom
alexr00/costly-lynx
Oct 7, 2026
Merged

Alex Ross (alexr00) merged 2 commits into
mainfrom
alexr00/costly-lynx

Conversation

@alexr00

Copy link
Copy Markdown
Member

No description provided.

@alexr00 Alex Ross (alexr00) self-assigned this Oct 7, 2026
@alexr00
Alex Ross (alexr00) marked this pull request as ready for review October 7, 2026 15:47
Copilot AI balanced review requested due to automatic review settings October 7, 2026 15:47
@alexr00
Alex Ross (alexr00) enabled auto-merge (squash) October 7, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The shared placeholder appears as non-clickable “Details” text in the activity-bar view.

1 open finding
What changed in this PR

Improves alignment of status-check actions in the PR checks view.

Changes:

  • Adds reserved slots for details links and log actions.
  • Standardizes action widths.
  • Adds coverage for status-check variants.
File Description
webviews/​components/​merge.tsx Adds action placeholders.
webviews/​editorWebview/​index.css Styles fixed-width action slots.
webviews/​editorWebview/​test/​overview.test.tsx Tests action rendering.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread webviews/components/merge.tsx
@alexr00
Alex Ross (alexr00) marked this pull request as draft October 7, 2026 15:53
auto-merge was automatically disabled October 7, 2026 15:53

Pull request was converted to draft

@alexr00
Alex Ross (alexr00) marked this pull request as ready for review October 7, 2026 16:01
Copilot AI balanced review requested due to automatic review settings October 7, 2026 16:01
@alexr00
Alex Ross (alexr00) enabled auto-merge (squash) October 7, 2026 16:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Content-box sizing leaves the log button wider than its placeholder, so alignment remains incorrect.

0 open findings

1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Real log button width differs from placeholder

webviews/​editorWebview/​index.css:385

This still gives the real log button a different width from the placeholder. .icon-button inherits a 1px border and sets 2px padding, and buttons remain content-box, so a 22px flex basis makes the button's outer width 28px while the empty span remains 22px. Add box-sizing: border-box so both slots actually occupy the same width.

🧠 Review effort: Balanced

@alexr00
Alex Ross (alexr00) merged commit e09f259 into main Oct 7, 2026
7 checks passed
@alexr00
Alex Ross (alexr00) deleted the alexr00/costly-lynx branch October 7, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants