Repository navigation
Add controlled icons to Button and ButtonLink - #19
Merged
Merged
Conversation
codefoxx
force-pushed
the
feat/button-icons
branch
from
September 13, 2026 17:44
aaeabad to
1d0dae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add controlled icon support to Button and ButtonLink while keeping icon layout owned by Codefox UI.
Closes #18
Included
iconprop on Button and ButtonLinkiconPositionvalues:startandendstartdirButtonIconPositiontype exportStacked PR
This PR is intentionally based on
feat/button-link/ PR #17 because ButtonLink is part of the change. Merge #17 first; after that this PR can be retargeted tomainwithout mixing the two feature reviews.Local visual review
Review
Primitives/Button / Overview,Primitives/Button / Playground,Primitives/ButtonLink / Overview, andPrimitives/ButtonLink / Playgroundin Storybook. No new dependencies were added.