Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
hope-999
force-pushed
the
command-palette-background
branch
from
September 30, 2026 09:00
1eb5ac4 to
36c584d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes
#50901 — allow the command palette background to differ from other dialogs
Type of change
What does this PR do?
Fixes #50901.
The command palette previously shared the dialog surface with every other dialog. This meant that themes with transparent dialogs could not give the command palette its own background without also making all other dialogs opaque.
This change adds an optional palette theme surface. The command palette opens using this surface, while other dialogs continue to use dialog. If a theme does not define @palette, it falls back to the existing @dialog surface, so existing themes keep their current appearance.
Theme authors can now configure it like this:
"@palette": {
"background": {
"base": "#202040"
}
}
test file:
palette-test.json
How did you verify your code works?
bun test test/cli/tui/command-palette.test.tsx
bun test test/theme/v2/resolve.test.ts
bun run check
Screenshots / recordings
Checklist