Repository navigation
add support for apps build with base configured - #41
Merged
Merged
Conversation
Owner
|
a whole new fixture app is the right way -- apps are cheap, and with a monorepo, we can test any configuration situation we can imagine ;) <3 |
Contributor
Author
|
woof that was a tough one to actually test 🫠 there is some heavy interplay between base, outDir, and rootURL 😬 Anyway I have added the test now and verified that it works locally 👍 Edit: I opened a quick PR on my fork to show that this fails without the fix: https://github.com/mansona/testem-code-coverage/actions/runs/36449973913/job/109021919603?pr=1#step:6:45 The output is swallowed by the CI setup but this is the error that I was getting before adding the fix: |
NullVoxPopuli
approved these changes
Sep 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for apps built with the base config option in Vite
I didn't really know how to test this other than creating a whole other fixture app 🤔 but I have verified this on a consuming app so I know it works fine 👍