Skip to content

add support for apps build with base configured - #41

Merged
NullVoxPopuli merged 2 commits into
NullVoxPopuli:mainfrom
mansona:support-base
Sep 28, 2026
Merged

NullVoxPopuli merged 2 commits into
NullVoxPopuli:mainfrom
mansona:support-base

Conversation

@mansona

@mansona mansona commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

This PR adds support for apps built with the base config option in Vite

I didn't really know how to test this other than creating a whole other fixture app 🤔 but I have verified this on a consuming app so I know it works fine 👍

@NullVoxPopuli

Copy link
Copy Markdown
Owner

a whole new fixture app is the right way -- apps are cheap, and with a monorepo, we can test any configuration situation we can imagine ;) <3

@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Sep 28, 2026
@mansona

mansona commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor Author

woof that was a tough one to actually test 🫠 there is some heavy interplay between base, outDir, and rootURL 😬

Anyway I have added the test now and verified that it works locally 👍

Edit: I opened a quick PR on my fork to show that this fails without the fix: https://github.com/mansona/testem-code-coverage/actions/runs/36449973913/job/109021919603?pr=1#step:6:45

The output is swallowed by the CI setup but this is the error that I was getting before adding the fix:

[coverage] No app-source coverage data after filtering — falling back to byte-level report.

Coverage Summary (byte-level)
──────────────────────────────────────────────────────────────────────────
File                                                Used B  Total B      %
──────────────────────────────────────────────────────────────────────────
face-face/@embroider/virtual/test-support.js           461      461   100%
face-face/@embroider/virtual/vendor.js                 316      316   100%
face-face/assets/app-DNcO-ENP.js                   2609114  2609114   100%
face-face/assets/tests-BP-Q9J2L.js                  410117   410117   100%
socket.io/socket.io.js                              155835   155835   100%
testem/testem_connection.js                           5692     5692   100%
──────────────────────────────────────────────────────────────────────────
Total                                              3181535  3181535   100%

@NullVoxPopuli
NullVoxPopuli merged commit b4316c5 into NullVoxPopuli:main Sep 28, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants